TEST: add unit tests for ConverterRegistry#1440
Merged
spencrr merged 1 commit intomicrosoft:mainfrom Mar 9, 2026
Merged
Conversation
spencrr
force-pushed
the
spencrr/registry-tests
branch
from
bfcc00f to
5b7889f
Compare
spencrr
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new unit test module for ConverterRegistry to validate basic singleton behavior, instance registration, metadata generation, and metadata filtering (via BaseInstanceRegistry.list_metadata) using lightweight mock converters.
Changes:
- Added mock
PromptConverterimplementations (text, image, and multi-modal) for registry testing. - Added tests for
ConverterRegistrysingleton lifecycle,register_instance,get_instance_by_name, and inherited container behaviors. - Added tests for metadata contents and include/exclude filtering behavior.
You can also share your feedback on Copilot code review. Take the survey.
romanlutz
approved these changes
Mar 6, 2026
spencrr
changed the title
spencrr
force-pushed
the
spencrr/registry-tests
branch
from
5b7889f to
03d324f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
riyosha
pushed a commit
to riyosha/PyRIT
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for
ConverterRegistrycovering:ComponentIdentifierintegrationBaseInstanceRegistrymethods (__contains__,__len__,__iter__,get_names,get_all_instances)Tests and Documentation
tests/unit/registry/test_converter_registry.py(26 tests)